fix: use index.d.ts as types for cjs #2114
Conversation
🦋 Changeset detectedLatest commit: 21d3e6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openapi-ts canceled.
|
size-limit report 📦
|
There was a problem hiding this comment.
I think this will fix it as this only builds one file. But when packages have multiple files and they import from one another, you have to generate a separate set of types generally (or manually redeclare types for every file. Unbuild does a really good job with this though, and agree we should just switch all packages to using that.
drwpow
deleted the
2098-build-output-is-missing-the-indexdcts-file-causing-typescript-to-fail
branch
|
Just letting you know that this doesn't work with typescript. The CJS output is now masquerading as ESM: https://arethetypeswrong.github.io/?p=openapi-react-query%400.3.1. The package.json was already correct. What needs to be done is to also publish the type declarations with |
Changes
This pull request closes #2098.
exports.require.typeswas pointing to a file that does not exist. It now points to the sameexports.imports.typesfile (index.d.ts) fixing type issues when using this library withrequire.How to Review
Types should properly resolved when using a
requireimport.